Skip to content

Conversation

@dg845
Copy link
Collaborator

@dg845 dg845 commented Oct 21, 2025

What does this PR do?

This PR is a continuation of #12442 by @tolgacangoz. It adds a pipeline for the Wan2.2-Animate-14B model (project page, paper, code, weights), a SOTA character animation and replacement video model.

Fixes #12441 (the original requesting issue).

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@yiyixuxu
@sayakpaul
@tolgacangoz

tolgacangoz and others added 30 commits October 6, 2025 21:46
- Introduced WanAnimateTransformer3DModel and WanAnimatePipeline.
- Updated get_transformer_config to handle the new model type.
- Modified convert_transformer to instantiate the correct transformer based on model type.
- Adjusted main execution logic to accommodate the new Animate model type.
…prove error handling for undefined parameters
…work for character animation and replacement

- Added Wan 2.2 Animate 14B model to the documentation.
- Introduced the Wan-Animate framework, detailing its capabilities for character animation and replacement.
- Included example usage for the WanAnimatePipeline with preprocessing steps and guidance on input requirements.
- Introduced `WanAnimateGGUFSingleFileTests` to validate functionality.
- Added dummy input generation for testing model behavior.
- Introduced `EncoderApp`, `Encoder`, `Direction`, `Synthesis`, and `Generator` classes for enhanced motion and appearance encoding.
- Added `FaceEncoder`, `FaceBlock`, and `FaceAdapter` classes to integrate facial motion processing.
- Updated `WanTimeTextImageMotionEmbedding` to utilize the new `Generator` for motion embedding.
- Enhanced `WanAnimateTransformer3DModel` with additional face adapter and pose patch embedding for improved model functionality.
- Introduced `pad_video` method to handle padding of video frames to a target length.
- Updated video processing logic to utilize the new padding method for `pose_video`, `face_video`, and conditionally for `background_video` and `mask_video`.
- Ensured compatibility with existing preprocessing steps for video inputs.
…roved video processing

- Added optional parameters: `conditioning_pixel_values`, `refer_pixel_values`, `refer_t_pixel_values`, `bg_pixel_values`, and `mask_pixel_values` to the `prepare_latents` method.
- Updated the logic in the denoising loop to accommodate the new parameters, enhancing the flexibility and functionality of the pipeline.
…eneration

- Updated the calculation of `num_latent_frames` and adjusted the shape of latent tensors to accommodate changes in frame processing.
- Enhanced the `get_i2v_mask` method for better mask generation, ensuring compatibility with new tensor shapes.
- Improved handling of pixel values and device management for better performance and clarity in the video processing pipeline.
…and mask generation

- Consolidated the handling of `pose_latents_no_ref` to improve clarity and efficiency in latent tensor calculations.
- Updated the `get_i2v_mask` method to accept batch size and adjusted tensor shapes accordingly for better compatibility.
- Enhanced the logic for mask pixel values in the replacement mode, ensuring consistent processing across different scenarios.
…nced processing

- Introduced custom QR decomposition and fused leaky ReLU functions for improved tensor operations.
- Implemented upsampling and downsampling functions with native support for better performance.
- Added new classes: `FusedLeakyReLU`, `Blur`, `ScaledLeakyReLU`, `EqualConv2d`, `EqualLinear`, and `RMSNorm` for advanced neural network layers.
- Refactored `EncoderApp`, `Generator`, and `FaceBlock` classes to integrate new functionalities and improve modularity.
- Updated attention mechanism to utilize `dispatch_attention_fn` for enhanced flexibility in processing.
…annotations

- Removed extra-abstractioned-functions such as `custom_qr`, `fused_leaky_relu`, and `make_kernel` to streamline the codebase.
- Updated class constructors and method signatures to include type hints for better clarity and type checking.
- Refactored the `FusedLeakyReLU`, `Blur`, `EqualConv2d`, and `EqualLinear` classes to enhance readability and maintainability.
- Simplified the `Generator` and `Encoder` classes by removing redundant parameters and improving initialization logic.
@dg845 dg845 marked this pull request as ready for review November 10, 2025 06:26
@dg845 dg845 requested a review from yiyixuxu November 10, 2025 06:27
@dg845
Copy link
Collaborator Author

dg845 commented Nov 10, 2025

Here are some diffusers samples starting from preprocessed inputs from the Wan2.2 official repo.

Animation:

wan_animate_video_20_step.mp4

Replacement:

wan_animate_video_replace_20_step.mp4

Copy link
Collaborator

@yiyixuxu yiyixuxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some comments.
It was a pleasure to review! really awesome work! @dg845

VAE scale factor. If `do_resize` is `True`, the image is automatically resized to multiples of this factor.
resample (`str`, *optional*, defaults to `lanczos`):
Resampling filter to use when resizing the image.
resample (`str`, *optional*, defaults to `"lanczos"`):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we add a new WanVaeImageProcessor(VaeImageProcessor) and put into wan folder, under utils.py file I think?
(we start to see more and more custom preprocess methods, almost everyone does and they don't really get reused across models, I think moving forward let's just do this for all new models)

cc @DN6 here too, let me know what you think

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the changes which make _resize_and_fill and _resize_and_crop respect self.config.resample should be added to the base VaeImageProcessor class; this could also be spun off into its own PR. I agree with moving the other (Wan Animate-specific logic) into its own class.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds good

Comment on lines +213 to +217
def __repr__(self):
return (
f"{self.__class__.__name__}(in_features={self.weight.shape[1]}, out_features={self.weight.shape[0]},"
f" bias={self.bias is not None})"
)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
def __repr__(self):
return (
f"{self.__class__.__name__}(in_features={self.weight.shape[1]}, out_features={self.weight.shape[0]},"
f" bias={self.bias is not None})"
)

hidden_states = hidden_states.flatten(2).transpose(1, 2)

# 3. Condition embeddings (time, text, image)
# timestep shape: batch_size, or batch_size, seq_len (wan 2.2 ti2v)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can move one of these conditions for animate, no?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, Wan Animate is based on Wan 2.1, so the Wan2.2 TI2V logic isn't necessary here, and I have removed it.


self.gradient_checkpointing = False

def motion_batch_encode(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we move this to forward? all the layers (motion_encoder here) should be visible in forward


hidden_states_original_dtype = hidden_states.dtype
hidden_states = self.norm_out(hidden_states.float())
# Move the shift and scale tensors to the same device as hidden_states.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ohh let's try to fix it here
I think all we need to do is to pack shift and scale into same layer and add that layere into _no_split_modules attribute

>>> face_video = load_video("path/to/face_video.mp4")
>>> # Calculate optimal dimensions based on VAE constraints
>>> max_area = 480 * 832
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if we make a vaeimageprocessor for wan, this can be added there too

@dg845 dg845 requested a review from yiyixuxu November 12, 2025 05:47
Copy link
Collaborator

@yiyixuxu yiyixuxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @dg845!
I've asked wan team to review this too, once they tested we can merge :)

@yiyixuxu yiyixuxu merged commit d8e4805 into huggingface:main Nov 13, 2025
9 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support Wan2.2-Animate

5 participants